Posted on August 5, 2008 by sharat
Automated Reviews
Automate the review where possible. A review conducted by a computer has several benefits:
Reduced manual cost of code reviews
Fast, consistent, and repeatable
Removes emotion from the reviews: pride, ego, and ownership need to be constantly recognized when conducting a review. When offering a critique you should take care to not to step on the author’s [...]
Filed under: Code Review | 1 Comment »
Posted on August 5, 2008 by sharat
Adherence to coding standards Writing to standards has several benefits, such as a shared vocabulary, which makes the code easier to reuse and maintain. One of the primary focuses of a code review is to ensure abidance with these norms. As you’ll see later, this benefit of a review is best derived in an automated [...]
Filed under: Code Review | Leave a Comment »
Posted on August 5, 2008 by sharat
Ask questions rather than make statements. A statement is accusatory. “You didn’t follow the standard here” is an attack—whether intentional or not. The question, “What was the reasoning behind the approached you used?” is seeking more information. Obviously, that question can’t be said with a sarcastic or condescending tone; but, done correctly, it can often [...]
Filed under: Code Review | Leave a Comment »